Sort metadata by keys when prettifying#151
Merged
ktoso merged 1 commit intoapple:masterfrom Sep 3, 2020
Merged
Conversation
Motivation: The stream log handler doesn't print metadata in a stable order. While swift-log is an API package and shouldn't provide all the bells and whistles for formatting logs, it should make the default log handler at least somewhat sensible. Modifications: - Sort the metadata by key when 'prettifying' it Result: - The stream log handler emits logs with metadata in a stable order - Resolves apple#128
|
Can one of the admins verify this patch? |
4 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
Member
|
@swift-server-bot add to whitelist |
Member
|
No reason to wait further, thanks a lot @glbrntt ! |
Member
|
Whoops oh no, this was still against master and it seems I forgot to re-target it... will submit against |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
The stream log handler doesn't print metadata in a stable order. While
swift-log is an API package and shouldn't provide all the bells and
whistles for formatting logs, it should make the default log handler
at least somewhat sensible.
Modifications:
Result: