Merged
Conversation
Lukasa
reviewed
Oct 20, 2025
Contributor
Lukasa
left a comment
There was a problem hiding this comment.
Can we also add derRepresentation properties to all of these? It's rarely useful to add one without the other.
Lukasa
reviewed
Oct 21, 2025
Contributor
|
Looks like a few tweaks need to be made. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add PEM/DER APIs for Curve25519
Checklist
If you've made changes to
gybfiles./scripts/generate_boilerplate_files_with_gyb.shand included updated generated files in a commit of this pull requestMotivation:
Closes #82
Creating Ed25519/X25519 keys using PEM/DER and also generating their PEM/DER representations can be handy
Modifications:
Added
init(pemRepresentation:)and thepemRepresentationcomputed propertyinit(derRepresentation:)and thederRepresentationcomputed propertyto
Curve25519.{Signing,KeyAgreement}.{Private,Public}KeyResult:
Curve25519 can now be created with and can produce PEM/DER representations