Update Kubernetes, Gradle, Pkl, Kotlin #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bioball
commented
Dec 9, 2025
bioball
commented
- Add support for Kubernetes 1.33 and 1.34
- Bump Pkl to 0.30
- Reformat generated code using Pkl formatter
- Bump Gradle to 9.2
- Bump Kotlin to 2.20
- Adjust license header year to 2024-2025 in generated package
* Add support for Kubernetes 1.33 and 1.34 * Bump Pkl to 0.30 * Reformat generated code using Pkl formatter * Bump Gradle to 9.2 * Bump Kotlin to 2.20 * Adjust license header year to 2024-2025 in generated package
HT154
reviewed
Dec 9, 2025
| @@ -38,7 +39,7 @@ private val resourceBaseProperties = setOf("apiVersion", "kind") | |||
|
|
|||
| private val licenseHeader = """ | |||
| //===----------------------------------------------------------------------===// | |||
| // Copyright © 2024 Apple Inc. and the Pkl project authors. All rights reserved. | |||
| // Copyright © 2024-2025 Apple Inc. and the Pkl project authors. All rights reserved. | |||
Contributor
There was a problem hiding this comment.
Can we make $currentYear dynamic?
HT154
reviewed
Dec 9, 2025
Comment on lines
+353
to
+354
| else -> { /* noop */ | ||
| } |
Contributor
There was a problem hiding this comment.
Wow this is a bizarre formatting decision!
HT154
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.