Skip to content

Add mypay.dfas.mil #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 27, 2024
Merged

Add mypay.dfas.mil #754

merged 3 commits into from
Sep 27, 2024

Conversation

@GeoJunkie
Copy link
Contributor

@GeoJunkie GeoJunkie commented Mar 13, 2024

Overall Checklist

for password-rules.json

  • The given rule isn't particularly standard and obvious for password managers
  • Generated passwords have been tested from this rule using the Password Rules Validation Tool
  • Information has been included about the website's requirements (eg. screenshots, error messages, steps during experimentation, etc.)
  • The PR isn't documenting something that would be a common practice among password managers (e.g. minimal length of 6)

for change-password-URLs.json

  • There is no Well-Known URL for Changing Passwords (https://example.com/.well-known/change-password)
  • The URL either makes the experience better or no worse than being directed to just the domain in a non-logged-in state

Site Requirements

From the password change page:
CleanShot 2024-03-13 at 10 17 58@2x

@erynofwales erynofwales self-assigned this Sep 27, 2024
@erynofwales
Remove the 'allowed' stipulation from the password rule
5e46218 
All characters in the 'required' list are 'allowed'.
@erynofwales erynofwales merged commit 4dbb424 into apple:main Sep 27, 2024
5 checks passed
rmondello pushed a commit to rmondello/password-manager-resources that referenced this pull request Nov 6, 2024
@GeoJunkie @erynofwales @rmondello
Add mypay.dfas.mil (apple#754)
d12b118 
* Add mypay.dfas.mil

* Adjust rules

Issues identified at https://developer.apple.com/password-rules/

* Remove the 'allowed' stipulation from the password rule

All characters in the 'required' list are 'allowed'.

---------

Co-authored-by: Eryn Wells <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erynofwales erynofwales erynofwales approved these changes

Assignees

@erynofwales erynofwales

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GeoJunkie @erynofwales