[container-build]: Support inline Dockerfile from stdin#827
Merged
jglogan merged 2 commits intoapple:mainfrom Nov 18, 2025
Merged
[container-build]: Support inline Dockerfile from stdin#827jglogan merged 2 commits intoapple:mainfrom
jglogan merged 2 commits intoapple:mainfrom
Conversation
saehejkang
force-pushed
the
container-build-support-inline-stdin
branch
from
96aad2b to
9a0d411
Compare
jglogan
requested changes
Nov 1, 2025
jglogan
requested changes
Nov 1, 2025
This was referenced Nov 1, 2025
saehejkang
force-pushed
the
container-build-support-inline-stdin
branch
from
71ea529 to
7b1c1fb
Compare
jglogan
added a commit
that referenced
this pull request
Nov 15, 2025
When working on test cases for #827 and #734 the following issues occurred 1. There was no support to pass in `Data` for `stdin` (input pipe added + new argument for the data) 2. Pipes were getting blocked during the `try process.run()` and `process.waitUntilExit()` (order of operations were fixed) 3. We need the binary data for directly piping the `stdout` data to `stdin`, and converting the data to a `string`, returns `""` (added a new value to the tuple) I opened a new PR here for this as I did not want to bloat the other PRs with so many updates. At first I thought of creating a new function named `runStdinStdout`, but that seemed redundant as it pretty much was going to do the same thing as `run`. ## Testing - [x] Tested locally - [x] Added/updated tests - [ ] Added/updated docs --------- Co-authored-by: J Logan <john_logan@apple.com>
saehejkang
force-pushed
the
container-build-support-inline-stdin
branch
2 times, most recently
from
5a5d3f7 to
54ef955
Compare
saehejkang
force-pushed
the
container-build-support-inline-stdin
branch
from
8deb0b0 to
4d961b9
Compare
jglogan
approved these changes
Nov 18, 2025
saehejkang
added a commit
to saehejkang/container
that referenced
this pull request
Jan 27, 2026
When working on test cases for apple#827 and apple#734 the following issues occurred 1. There was no support to pass in `Data` for `stdin` (input pipe added + new argument for the data) 2. Pipes were getting blocked during the `try process.run()` and `process.waitUntilExit()` (order of operations were fixed) 3. We need the binary data for directly piping the `stdout` data to `stdin`, and converting the data to a `string`, returns `""` (added a new value to the tuple) I opened a new PR here for this as I did not want to bloat the other PRs with so many updates. At first I thought of creating a new function named `runStdinStdout`, but that seemed redundant as it pretty much was going to do the same thing as `run`. ## Testing - [x] Tested locally - [x] Added/updated tests - [ ] Added/updated docs --------- Co-authored-by: J Logan <john_logan@apple.com>
saehejkang
added a commit
to saehejkang/container
that referenced
this pull request
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
Closes #727
Tested variations of commands with
stdinbelowTesting