ImagePush: print image reference to stdout on success#1470
Merged
jglogan merged 1 commit intoapple:mainfrom Apr 30, 2026
Merged
ImagePush: print image reference to stdout on success#1470jglogan merged 1 commit intoapple:mainfrom
jglogan merged 1 commit intoapple:mainfrom
Conversation
Resolves apple#1466. `container image push <ref>` previously produced no standard output on success. Print the fully qualified reference (`image.reference`) after the push completes so callers can pipe the output into subsequent commands. This matches the existing pattern in `ImageTag.run()`, which prints the resolved target after `existing.tag(new: targetReference)`.
jglogan
approved these changes
Apr 30, 2026
Contributor
|
@mvanhorn Thanks for tackling that so quickly! |
Contributor
Author
|
Thanks @jglogan! Glad it landed. |
noah-thor
pushed a commit
to noah-thor/container
that referenced
this pull request
May 6, 2026
-Resolves apple#1466. - `container image push <ref>` previously produced no standard output on success. Print the fully qualified reference (`image.reference`) after the push completes so callers can pipe the output into subsequent commands. Co-authored-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1466.
container image push <ref>previously produced no standard output on success. Print the fully qualified reference (image.reference) after the push completes so callers can pipe the output into subsequent commands.The issue raised the question: "echo back the supplied reference, or print the fully qualified reference?" — this PR prints
image.reference, which is the normalized/fully-qualified form (e.g.docker.io/max-mustermann/scratch/test:latestfrom the issue's example), matching the same field thatImagePulland the progress bar already use.This mirrors the existing pattern in
ImageTag.run(), which prints the resolved target after the tag completes:Diff: 1 line.