Skip to content

Don't bake DNS server into builder container config. #1370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jglogan merged 1 commit into from
Mar 31, 2026
Merged

Don't bake DNS server into builder container config. #1370

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions Sources/ContainerCommands/Builder/BuilderStart.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,17 +267,14 @@ extension Application {
guard let defaultNetwork = try await ClientNetwork.builtin else {
throw ContainerizationError(.invalidState, message: "default network is not present")
}
guard case .running(_, let networkStatus) = defaultNetwork else {
guard case .running(_, _) = defaultNetwork else {
throw ContainerizationError(.invalidState, message: "default network is not running")
}
config.networks = [
AttachmentConfiguration(network: defaultNetwork.id, options: AttachmentOptions(hostname: Builder.builderContainerId))
]
let subnet = networkStatus.ipv4Subnet
let nameserver = IPv4Address(subnet.lower.value + 1).description
let nameservers = dnsNameservers.isEmpty ? [nameserver] : dnsNameservers
config.dns = ContainerConfiguration.DNSConfiguration(
nameservers: nameservers,
nameservers: dnsNameservers,
domain: dnsDomain,
searchDomains: dnsSearchDomains,
options: dnsOptions
Expand Down
Loading