Add TestCLIVersion to integration tests and fix assertions#1312
Merged
Conversation
tico88612
changed the title
vxnkjyffmq-code
approved these changes
Mar 15, 2026
vxnkjyffmq-code
approved these changes
Mar 15, 2026
Contributor
Author
tico88612
force-pushed
the
test/system-version
branch
from
cb82b1c to
77ebfc5
Compare
vxnkjyffmq-code
suggested changes
Mar 20, 2026
tico88612
force-pushed
the
test/system-version
branch
from
77ebfc5 to
fef9863
Compare
Contributor
Author
|
@JaewonHur, could you take a look at this? It's to cover the parts that weren't tested before. |
Contributor
|
Could you make signed commits? |
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
tico88612
force-pushed
the
test/system-version
branch
from
fef9863 to
1d9f7e5
Compare
Contributor
Author
@JaewonHur Resigned. I guess GitHub-UI rebase will remove my signed commit. |
JaewonHur
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
TestCLIVersionisn't in the integration test; we should include this.And update the output to align with the real output.
Follow up #911
Testing