Update builder API to use grpc-swift-2.#1309
Conversation
- Closes apple#1308. - Applies dependency and code changes similar to apple/containerization#578. - Upgrades hawkeye to latest version. - Update StderrLogHandler not to create a (non-Sendable) Swift time formatter object for every log message.
| initialBackoff: TimeInterval(1), | ||
| maximumBackoff: TimeInterval(10) | ||
|
|
||
| let channel = try ClientBootstrap(group: group) |
There was a problem hiding this comment.
Replace grpc-swift client setup with the grpc-swift-2 approach, initializing our buffering handler in place to deal with the server sending the SETTINGS frame before the pipeline can handle it.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| try channel.pipeline.syncOperations.addHandler(HTTP2ConnectBufferingHandler()) | ||
| }) | ||
| } | ||
| .withConnectedSocket(socket.fileDescriptor) |
There was a problem hiding this comment.
the fd for the vsock between us and the buildkit container
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
We've already reviewed this approach in apple/containerization#578
| switch logLevel { | ||
| case .debug, .trace: | ||
| let timestamp = ISO8601DateFormatter().string(from: Date()) | ||
| let timestamp = isoTimestamp() |
There was a problem hiding this comment.
Let's not construct a non-Sendable date formatter every log message.
- Closes apple#1308. - Applies dependency and code changes similar to apple/containerization#578. - Upgrades hawkeye to latest version. - Update StderrLogHandler not to create a (non-Sendable) Swift time formatter object for every log message.
- Closes #1308. - Applies dependency and code changes similar to apple/containerization#578. - Upgrades hawkeye to latest version. - Update StderrLogHandler not to create a (non-Sendable) Swift time formatter object for every log message.
3 participants
Type of Change
Motivation and Context
The new library is more actively maintained
Testing