Change the verification example to use the main type interface #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The interface "@apple/app-store-server-library" exposes SignedJWTVerifier as the external type to be used. All other examples use this interface.
Author
|
Sorry for closing it and reopening. |
Collaborator
|
This has been superseded by #40, thank you for the report, the exported name was incorrect at should not have referenced a JWT, as these values are JWS not JWT, and has been updated to match the other libraries |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation Contribution
The interface at "@apple/app-store-server-library" exposes
SignedJWTVerifieras the external type to be used.All other examples use this interface as reference for their imported types.
But Verification Usage was importing directly the inner type
SignedDataVerifier.To make it easier to new devs to onboard on the library, this PR conforms the example to the same interface and expected type.
Thanks for maintaining this project and making our lives easier working with IAP 🥳