Document error codes #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
index.ts
Outdated
| /** | ||
| * Error codes that App Store Server API responses return. | ||
| * | ||
| * {@link https://developer.apple.com/documentation/appstoreserverapi/error_codes Error Codes} |
Collaborator
There was a problem hiding this comment.
Please update this to use a lowercase c to match the documentation
Contributor
Author
There was a problem hiding this comment.
Thanks. I have updated this.
Collaborator
|
@rodrigoborgesdeoliveira Thank you for the PR, I've left one minor comment. Also your PR will likely conflict with the new error codes added in #27 |
Contributor
Author
|
Thank you for the heads up on the new error codes, @alexanderjordanbaker. I have resolved the conflicts and documented the new error codes as well. Please let me know if there are any other pending issues. |
alexanderjordanbaker
approved these changes
Nov 4, 2023
Collaborator
|
Apologies for the delay, this looks good, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.