feat: add sessionName in the attach to session dropdown#1694
Conversation
|
What's the |
|
btw, please sign the CLA |
Yes, it's not an appium capability, this capability is specific to BrowserStack by which we allow the user's to give a meaningful name to their sessions. |
|
Could it be possible to build your own custom AD for your platform with this change? It would be better to define a new module or method to allow a vendor to customize the naming for them. function formatCaps (vendor, caps) {
if (vendor === 'browserstack') {
return formatCapsBrowserStack(caps)
}
// ...
}
function formatCapsBrowserStack (caps) {
// do your own logic
}Or extract the place as a different module. |
|
@KazuCocoa can you re-review? I've created the method |
# Conflicts: # app/renderer/components/Session/AttachToSession.js
Once #1693 is merged users will be able to view the list of running sessions in the attach to session window. It is difficult to filter the sessions via the session-id, therefore, adding the
sessionName(if present) to the list ofimportantCaps.Screenshot from the dev build
