In apos-global, joinByOne in an object is not resolved in Live mode. (underlying id not updated to point to Live ver when commit)

[ericwong3]

In apostrophe-global, when there is an object field containing a joinByOne field, the relationship is not resolved as expected when in Live mode, the field will be missing completely (and the ID field will retain draft version's ID).

Steps to Reproduce

1. Start an empty project with apostrophe cli and npm i inside
2. cd into the new project and do npm install --save apostrophe-workflow
3. Add the default snippet

'apostrophe-workflow': {
  // IMPORTANT: if you follow the examples below,
  // be sure to set this so the templates work
  alias: 'workflow',
  // Recommended to save database space. You can still
  // export explicitly between locales
  replicateAcrossLocales: false
},
'apostrophe-workflow-modified-documents': {}

4. Create lib/modules/apostrophe-global/index.js with the following content:

module.exports = {
  addFields: [
    {
      name: 'demoField',
      label: 'Demo Field',
      type: 'object',
      schema: [{
        "type": "joinByOne",
        "required": true,
        "name": "_demoFieldInner",
        "label": "Demo Field Inner",
        "withType": "apostrophe-page",
      }],
    },
    
    {
      "type": "joinByOne",
      "required": true,
      "name": "_demoField2",
      "label": "Demo Field 2",
      "withType": "apostrophe-page",
    }
  ]
}

4. In lib/modules/apostrophe-pages/views/pages/home.html, add <script>console.log({{ data.global|json }})</script> for testing.
5. Start the app, login as admin, edit Global, for both field pick Home itself, then save draft, open Global again, commit.
6. In Draft mode, observe in terminal that demoField2Id, _demoField2, demoField.demoFieldInnerId, demoField._demoFieldInner are all present as expected:
   
7. Switch to Live mode, observe in terminal that demoField2Id, _demoField2, and demoField.demoFieldInnerId are present, but demoField._demoFieldInner is not. Moreover, the ID in demoField.demoFieldInnerId is still storing draft version's ID (maybe hinting the commit flow is forgetting to update this ID to point to the Live home page's ID):
   

Notes
The field setup should be valid, this works perfectly fine before workflow module is installed.

[ericwong3]

any updates :(

[ericwong3]

I dug into the core and applied this patch, apparently does the trick:

diff --git a/node_modules/apostrophe-workflow/lib/implementation.js b/node_modules/apostrophe-workflow/lib/implementation.js
index 22be6fc..1a6d573 100644
--- a/node_modules/apostrophe-workflow/lib/implementation.js
+++ b/node_modules/apostrophe-workflow/lib/implementation.js
@@ -348,6 +348,9 @@ module.exports = function(self, options) {
               fromArrays = fromArrays.concat(self.findJoinsInSchema(doc, field.schema));
             });
           }
+          if (field.type === 'object' && typeof doc[field.name] === 'object') {
+            fromArrays = fromArrays.concat(self.findJoinsInSchema(doc[field.name], field.schema));
+          }
         }
       ), function(field) {
         return { doc: doc, field: field, value: doc[field.name] };

[boutell]

Thank you very much for this fix! We've been keeping your bug report in our queue but had a lot of deadlines for enterprise customers this week, and coincidentally we weren't sure why they hadn't mentioned the bug. The answer of course is that they weren't using object fields in the same way you are. I'd like to send you some Apostrophe swag; if you'd like a T-shirt, please drop me a line at tom@apostrophecms.com with your mailing address. Thanks!

…

On Mon, Nov 18, 2019 at 4:14 AM Eric Wong ***@***.***> wrote: I dug into the core and applied this patch, apparently does the trick: diff --git a/node_modules/apostrophe-workflow/lib/implementation.js b/node_modules/apostrophe-workflow/lib/implementation.js index 22be6fc..1a6d573 100644--- a/node_modules/apostrophe-workflow/lib/implementation.js+++ b/node_modules/apostrophe-workflow/lib/implementation.js@@ -348,6 +348,9 @@ module.exports = function(self, options) { fromArrays = fromArrays.concat(self.findJoinsInSchema(doc, field.schema)); }); }+ if (field.type === 'object' && typeof doc[field.name] === 'object') {+ fromArrays = fromArrays.concat(self.findJoinsInSchema(doc[field.name], field.schema));+ } } ), function(field) { return { doc: doc, field: field, value: doc[field.name] }; — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#283>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAH27KLD3BS6VPP5GITGALQUJMI7ANCNFSM4JI7SZHQ> .

-- THOMAS BOUTELL | CHIEF TECHNOLOGY OFFICER APOSTROPHECMS | apostrophecms.com | he/him/his

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.