fix importAttributes is not avaliable in old node versions#226
Conversation
|
@yesmeck: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
913e6ae to
70d5deb
Compare
|
I'm merging in |
…phql into fix/import-attributes
Co-authored-by: Lenz Weber-Tronic <[email protected]>
Co-authored-by: Lenz Weber-Tronic <[email protected]>
|
Generally, could you please add some comment to document that once we hit a minimum of 1.92, most of these workarounds can be removed again, and reference the issue you started? |
|
Okay, once the tests come back happy all that's left is a changeset - could you please run |
|
Huh, that test runs fine for me locally. I'll investigate. |
… github.com:yesmeck/vscode-graphql into fix/import-attributes
|
It seems we can't set |
|
This is just super weird :( |
|
Can you rerun CI? It works for me locally now. We need to set both |
phryneas
left a comment
There was a problem hiding this comment.
And we're green.
Thank you very much for your hard work with this!
fix #225
Tested with VSCode 1.91.1 (Node.js 20.9.0) and VSCode 1.94.0 (Node.js 20.16.0).