Skip to content

feat: allow graphql v17 as a peer dependency - #25

Merged
dariuszkuc merged 1 commit into
mainfrom
graphql-17-peer
Nov 11, 2026
Merged

dariuszkuc merged 1 commit into
mainfrom
graphql-17-peer

Conversation

@glasser

@glasser glasser commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

Summary

This package works properly with both graphql v16 or v17 without code changes. This PR expands the peer dependency to allow either, and runs CI against both.

Note: the compatibility suite uses Apollo Server, and as of this moment Apollo Server only supports graphql v16, so we keep the compatibility suite only running on v16. (This PR is part of the process of working towards Apollo Server v6, which will support and require graphql v17.)

🤖 Generated with Claude Code

Widen the peer range to ^16.11.0 || ^17.0.0 and run CI against both
majors. The root devDependency stays on v16 so the compatibility suite,
which runs this package inside Apollo Server v5 (a graphql v16 consumer),
keeps a single copy of graphql; the v17 CI jobs swap it in after npm ci.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@glasser
glasser marked this pull request as ready for review November 11, 2026 23:05
@glasser
glasser requested a review from dariuszkuc November 11, 2026 23:05
@dariuszkuc
dariuszkuc merged commit 2085b86 into main Nov 11, 2026
8 checks passed
@dariuszkuc
dariuszkuc deleted the graphql-17-peer branch November 11, 2026 23:07
@github-actions github-actions Bot mentioned this pull request Nov 11, 2026
dariuszkuc pushed a commit that referenced this pull request Nov 11, 2026
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @apollo/subgraph@2.16.0

### Minor Changes

- [#25](#25)
[`2085b86`](2085b86)
Thanks [@glasser](https://github.com/glasser)! - Allow `graphql` v17 as
a peer dependency (`^16.11.0 || ^17.0.0`). CI now runs the test suite
against both v16 and v17.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants