Skip to content

fix: restore Node.js 22 LTS support - #17

Merged
dariuszkuc merged 1 commit into
apollographql:mainfrom
marklai1998:fix/restore-node-22-support
Sep 14, 2026
Merged

dariuszkuc merged 1 commit into
apollographql:mainfrom
marklai1998:fix/restore-node-22-support

Conversation

@marklai1998

@marklai1998 marklai1998 commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Close #16

Summary

  • Restore engines.node to >=22.0.0. The graphql-js rewrite set it to >=24.0.0 with no documented Node 24 runtime requirement, so Node 22 LTS installs failed.
  • Run the unit/build matrix on Node 22 as well as 24 and latest.
  • Document the Node 22 floor in the README and add a patch changeset.

Test plan

  • Confirm npm pack / install on Node 22 no longer reports an engines mismatch
  • Confirm CI Build job runs and passes on Node 22, 24, and latest
  • Compatibility suite can stay on Node 24 (@apollo/federation-subgraph-compatibility still requires >=24)

engines.node was >=24.0.0 after the graphql-js rewrite with no
documented Node 24 requirement, so Node 22 LTS installs failed.
@apollo-cla

Copy link
Copy Markdown

@marklai1998: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@marklai1998

Copy link
Copy Markdown
Contributor Author

@dariuszkuc could you spend some time to look at it?? Thanks!

@dariuszkuc
dariuszkuc merged commit de906c3 into apollographql:main Sep 14, 2026
5 checks passed
@github-actions github-actions Bot mentioned this pull request Sep 14, 2026
dariuszkuc pushed a commit that referenced this pull request Sep 14, 2026
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @apollo/subgraph@2.15.1

### Patch Changes

- [#17](#17)
[`de906c3`](de906c3)
Thanks [@marklai1998](https://github.com/marklai1998)! - Restore Node.js
22 support. `engines.node` was set to `>=24.0.0` during the graphql-js
rewrite without a documented Node 24 runtime requirement, which silently
dropped the current Node 22 LTS. CI now tests Node 22 alongside 24 and
latest.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incompatible with Node LTS(Node 22)

3 participants