Skip to content

Conversation

@carodewig
Copy link
Contributor

Several small fixes for Redis behaviors observed during hot-reload.

  1. Client errors were being logged twice; remove the duplication 66fc504
  2. Stop the heartbeat task before calling quit on clients to eliminate extra reconnection
  3. Add further context to log message about when error occurred (ie during client startup, during query execution)

Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • PR description explains the motivation for the change and relevant context for reviewing
  • PR description links appropriate GitHub/Jira tickets (creating when necessary)
  • Changeset is included for user-facing changes
  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Metrics and logs are added3 and documented
  • Tests added and passing4
    • Unit tests
    • Integration tests
    • Manual tests, as necessary

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices.

  4. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@carodewig carodewig requested a review from a team as a code owner December 9, 2025 20:16
@apollo-librarian
Copy link

apollo-librarian bot commented Dec 9, 2025

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: ec1aebe32abccb6e8b732819
Build Logs: View logs

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

@carodewig, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

@carodewig carodewig merged commit 53019ca into dev Dec 10, 2025
15 checks passed
@carodewig carodewig deleted the caroline/fix-redis-shutdown-order branch December 10, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants