Adapt connectors expansion and validation to handle abstract types (interfaces and unions) #8143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: dec2409d5cdf91b7c16e84b1 |
benjamn
force-pushed
the
benjamn/connectors-abstract-types-validation-and-expansion
branch
2 times, most recently
from
4244cb9 to
6aef3e2
Compare
benjamn
force-pushed
the
benjamn/connectors-abstract-types-validation-and-expansion
branch
from
7e3a018 to
daa3c07
Compare
benjamn
changed the base branch from
am/connectorspreview
to
benjamn/dynamic-connectors-response-mapping
benjamn
force-pushed
the
benjamn/dynamic-connectors-response-mapping
branch
2 times, most recently
from
a7d8dc6 to
542122e
Compare
benjamn
force-pushed
the
benjamn/connectors-abstract-types-validation-and-expansion
branch
from
daa3c07 to
58c3f1e
Compare
benjamn
changed the base branch from
benjamn/dynamic-connectors-response-mapping
to
benjamn/better-nullish-coalescing-union-shapes
Base automatically changed from
benjamn/better-nullish-coalescing-union-shapes
to
benjamn/dynamic-connectors-response-mapping
September 7, 2025 14:57
benjamn
force-pushed
the
benjamn/dynamic-connectors-response-mapping
branch
from
4ae2941 to
eef1acc
Compare
benjamn
force-pushed
the
benjamn/dynamic-connectors-response-mapping
branch
from
eef1acc to
43f056a
Compare
benjamn
force-pushed
the
benjamn/connectors-abstract-types-validation-and-expansion
branch
from
58c3f1e to
d136783
Compare
benjamn
force-pushed
the
benjamn/connectors-abstract-types-validation-and-expansion
branch
from
d136783 to
331d46f
Compare
benjamn
force-pushed
the
benjamn/dynamic-connectors-response-mapping
branch
from
2a35586 to
756e131
Compare
benjamn
force-pushed
the
benjamn/connectors-abstract-types-validation-and-expansion
branch
from
331d46f to
4655d8e
Compare
benjamn
force-pushed
the
benjamn/dynamic-connectors-response-mapping
branch
2 times, most recently
from
0c91f46 to
d355501
Compare
benjamn
force-pushed
the
benjamn/connectors-abstract-types-validation-and-expansion
branch
from
4655d8e to
51ded4c
Compare
Member
Author
|
Going back to draft status because this PR needs a rework to make better use of |
Base automatically changed from
benjamn/dynamic-connectors-response-mapping
to
dev
November 12, 2025 15:37
benjamn
force-pushed
the
benjamn/connectors-abstract-types-validation-and-expansion
branch
from
51ded4c to
2d03e6b
Compare
Contributor
|
@benjamn, please consider creating a changeset entry in |
benjamn
force-pushed
the
benjamn/connectors-abstract-types-validation-and-expansion
branch
from
2d03e6b to
018fdc8
Compare
benjamn
force-pushed
the
benjamn/connectors-abstract-types-validation-and-expansion
branch
from
018fdc8 to
2c0bb3c
Compare
benjamn
changed the base branch from
dev
to
benjamn/SchemaTypeRef-instead-of-Node-ObjectType
Member
Author
|
Update: this PR has gotten a lot simpler (just two commits now!), but I still need to add proper |
benjamn
force-pushed
the
benjamn/SchemaTypeRef-instead-of-Node-ObjectType
branch
from
a93d0b6 to
f3aafe4
Compare
benjamn
force-pushed
the
benjamn/connectors-abstract-types-validation-and-expansion
branch
from
2c0bb3c to
65f2f4d
Compare
benjamn
force-pushed
the
benjamn/SchemaTypeRef-instead-of-Node-ObjectType
branch
from
a77dfd2 to
8d679e0
Compare
benjamn
force-pushed
the
benjamn/connectors-abstract-types-validation-and-expansion
branch
from
f769f51 to
1e6c80d
Compare
benjamn
force-pushed
the
benjamn/SchemaTypeRef-instead-of-Node-ObjectType
branch
from
8d679e0 to
eaf069f
Compare
benjamn
force-pushed
the
benjamn/connectors-abstract-types-validation-and-expansion
branch
from
1e6c80d to
9cd4372
Compare
benjamn
force-pushed
the
benjamn/SchemaTypeRef-instead-of-Node-ObjectType
branch
from
eaf069f to
e16d56d
Compare
benjamn
force-pushed
the
benjamn/connectors-abstract-types-validation-and-expansion
branch
from
9cd4372 to
1aafc27
Compare
benjamn
force-pushed
the
benjamn/SchemaTypeRef-instead-of-Node-ObjectType
branch
from
e16d56d to
9f44e1c
Compare
benjamn
force-pushed
the
benjamn/connectors-abstract-types-validation-and-expansion
branch
from
1aafc27 to
f823c7d
Compare
benjamn
force-pushed
the
benjamn/SchemaTypeRef-instead-of-Node-ObjectType
branch
from
9f44e1c to
41756d9
Compare
benjamn
force-pushed
the
benjamn/connectors-abstract-types-validation-and-expansion
branch
4 times, most recently
from
ca6ee21 to
53fc018
Compare
Note that we now have distinct `NamedSelection::parse_v0_3` and `NamedSelection::parse_v0_4` functions to preserve the differences between the versions for backwards/forwards compatibility.
Note: shape-based validation does work for v0.3, since -> method shape checking was quietly reenabled in v0.3 to support URI templating validation and a few other use cases, but it's important to match the old behavior we shipped.
benjamn
force-pushed
the
benjamn/SchemaTypeRef-instead-of-Node-ObjectType
branch
from
41756d9 to
56ab2fc
Compare
benjamn
force-pushed
the
benjamn/connectors-abstract-types-validation-and-expansion
branch
from
53fc018 to
d6d88b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This PR builds on #8616 and #8626
Supporting the
...syntax in the JSONSelection mapping language (PR #7957) allowed for conditional selections, which allows for conditionally determining the__typenameof an object in GraphQL, which enables the use of abstract types (or type polymorphism): interfaces and union types that might be one of several concrete types, with the exact__typenameand associated fields determined at runtime.This PR updates the rest of the connectors system (beyond the JSONSelection language) to tolerate abstract types: relaxing validation to allow for abstract types, but also validating the fields of each concrete type; rewriting expansion to understand interfaces, unions, and JSONSelection strings that compute their
__typenameand other fields; and updating theshapecrate to support this new functionality. The new expansion and validation traversal logic is nowShape-based, which is the achievement that allows for static analysis of conditional__typenameselections.