v5: actually drop Express from the main package's dependencies #8094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glasser
commented
Jul 2, 2025
| "@types/async-retry": "1.4.9", | ||
| "@types/body-parser": "1.19.6", | ||
| "@types/cors": "2.8.19", | ||
| "@types/express": "^4.17.13", |
Member
Author
There was a problem hiding this comment.
Needed because the integration test suite uses Express to set up a non-GraphQL server
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Forgot to do this previously when making the standalone server not use Express.
glasser
force-pushed
the
glasser/v5-really-no-express
branch
from
c1ec051 to
77ca0bb
Compare
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: 4849cd4342f1b9db9a79d807 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot to do this previously when making the standalone server not use Express.