[do not merge] 0.4.21 fixes #783
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
react-apollo calls setOptions and ignores the return value. Sometimes setOptions calls this.result() which subscribes and unsubscribes to the query, but this actually unsubscribes the main subscription too, which is bad. We should fix the underlying bug but until then react-apollo can call _setOptionsNoResult instead.
(this test fails if you use `setVariables`
Contributor
Author
|
Fixed in #791 |
Member
|
Great. Since we never added the hacky APIs on master, and react-apollo's current release won't pull in apollo-client 0.5.x, all we need to do is wait for apollo-client to come out, change react-apollo to request apollo-client 0.5.x, and revert the use of the hacky API to using the normal version. |
Contributor
Author
|
@glasser on it! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening to keep track of the diff.