Skip to content

[WIP] Feedback from open incremental PRs #13010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 14 commits into
base: release-4.1
Choose a base branch
from
Draft

[WIP] Feedback from open incremental PRs #13010

wants to merge 14 commits into from

Conversation

@jerelmiller
Copy link
Member

@jerelmiller jerelmiller commented Nov 13, 2025

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Nov 13, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: aed023f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 13, 2025 •
edited
Loading 

npm i https://pkg.pr.new/apollographql/apollo-client/@apollo/client@13010

commit: e9cf840

phryneas
phryneas reviewed Nov 13, 2025
View reviewed changes
src/link/error/__tests__/index.ts
extensions: {
code: "INCREMENTAL_ERROR",
},
path: ["foo", "bar"],
Copy link
Member

@phryneas phryneas Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh, so errors come in with a complete path, not with a sub-path. I hadn't been aware of that - that makes this a lot easier to handle than I feared!

Copy link
Member Author

@jerelmiller jerelmiller Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! Thankfully we don't have to concatenate paths at all 🙂

@jerelmiller jerelmiller mentioned this pull request Nov 13, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phryneas phryneas phryneas left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jerelmiller @phryneas