Don't attempt to connect to devtools in non-browser environments

[jerelmiller]

This was mostly already doing this. With #11969, we removed the check for typeof window to set the default value for devtools.enabled. The connectToDevtools function has some checks for typeof window as well, but currently it allows the setTimeout to run before it checks for typeof window.

This PR simplifies this by returning early if typeof window is undefined.

[changeset-bot]

🦋 Changeset detected

Latest commit: 272000f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@apollo/client	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

size-limit report 📦

Path	Size
dist/apollo-client.min.cjs	39.22 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs"	47.88 KB (+0.01% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production)	45.45 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js"	34.31 KB (-0.02% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production)	32.2 KB (-0.01% 🔽)
import { ApolloProvider } from "dist/react/index.js"	1.26 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production)	1.24 KB (0%)
import { useQuery } from "dist/react/index.js"	5.21 KB (0%)
import { useQuery } from "dist/react/index.js" (production)	4.3 KB (0%)
import { useLazyQuery } from "dist/react/index.js"	5.69 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production)	4.77 KB (0%)
import { useMutation } from "dist/react/index.js"	3.62 KB (0%)
import { useMutation } from "dist/react/index.js" (production)	2.84 KB (0%)
import { useSubscription } from "dist/react/index.js"	4.41 KB (0%)
import { useSubscription } from "dist/react/index.js" (production)	3.46 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js"	5.49 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production)	4.15 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js"	4.99 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production)	3.64 KB (0%)
import { useLoadableQuery } from "dist/react/index.js"	5.07 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production)	3.72 KB (0%)
import { useReadQuery } from "dist/react/index.js"	3.39 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production)	3.33 KB (0%)
import { useFragment } from "dist/react/index.js"	2.32 KB (0%)
import { useFragment } from "dist/react/index.js" (production)	2.27 KB (0%)

[phryneas]

Can you move this whole check (apart from the __APOLLO_DEVTOOLS_GLOBAL_HOOK_) around the setTimeout?

No need to schedule a timeout that won't do anything.

[jerelmiller]

Certainly!

[jerelmiller]

6a52c58

[phryneas]

!(window as any).__APOLLO_DEVTOOLS_GLOBAL_HOOK__ &&

This line needs to be inside the setTimeout though as it should check after 10s - sorry for being confusing! 😅

[jerelmiller]

Yep just realized that 😆. I'm trying to move too fast and do too many things at once!

[phryneas]

🐌 🐌 🐌

[jerelmiller]

Perhaps this is the right combination: 272000f

[netlify]

✅ Deploy Preview for apollo-client-docs ready!

Name	Link
🔨 Latest commit	cef8ebb
🔍 Latest deploy log	https://app.netlify.com/sites/apollo-client-docs/deploys/669fc11413b16a0008c9b8e3
😎 Deploy Preview	https://deploy-preview-11971--apollo-client-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[phryneas]

Looks good to me

[netlify]

✅ Deploy Preview for apollo-client-docs ready!

Name	Link
🔨 Latest commit	6a52c58
🔍 Latest deploy log	https://app.netlify.com/sites/apollo-client-docs/deploys/669fc1f32f1ed400086db8ea
😎 Deploy Preview	https://deploy-preview-11971--apollo-client-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[netlify]

✅ Deploy Preview for apollo-client-docs ready!

Name	Link
🔨 Latest commit	272000f
🔍 Latest deploy log	https://app.netlify.com/sites/apollo-client-docs/deploys/669fc2a9ff55810008e96f9f
😎 Deploy Preview	https://deploy-preview-11971--apollo-client-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.