Skip to content

Navigation Menu

Appearance settings

GitHub Copilot
Write better code with AI

GitHub Spark New
Build and deploy intelligent apps

GitHub Models New
Manage and compare prompts

GitHub Advanced Security
Find and fix vulnerabilities

Actions
Automate any workflow
Codespaces
Instant dev environments

Issues
Plan and track work

Code Review
Manage code changes

Discussions
Collaborate outside of code

Code Search
Find more, search less
Explore

Why GitHub

Documentation

GitHub Skills

Blog
Integrations

GitHub Marketplace

MCP Registry
View all features
By company size

Enterprises

Small and medium teams

Startups

Nonprofits
By use case

App Modernization

DevSecOps

DevOps

CI/CD

View all use cases
By industry

Healthcare

Financial services

Manufacturing

Government

View all industries
View all solutions
Topics

AI

DevOps

Security

Software Development

View all
Explore

Learning Pathways

Events & Webinars

Ebooks & Whitepapers

Customer Stories

Partners

Executive Insights
GitHub Sponsors
Fund open source developers
The ReadME Project
GitHub community articles
Repositories

Topics

Trending

Collections
Enterprise platform
AI-powered developer platform
Available add-ons

GitHub Advanced Security
Enterprise-grade security features

Copilot for business
Enterprise-grade AI features

Premium Support
Enterprise-grade 24/7 support
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

Appearance settings

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

apollographql / apollo-client Public

Notifications You must be signed in to change notification settings
Fork 2.7k
Star 19.7k

Code
Issues 382
Pull requests 39
Actions
Projects
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Projects
Security
Insights

`useSuspenseQuery`#10323

Merged

alessbell merged 159 commits intorelease-3.8apollographql/apollo-client:release-3.8from

react-suspenseapollographql/apollo-client:react-suspenseCopy head branch name to clipboard

Dec 9, 2022

Conversation Commits159 (159)Checks Files changed

Merged

`useSuspenseQuery`#10323
alessbell merged 159 commits intorelease-3.8from
react-suspense

Commits

Commits on Dec 8, 2022

fix(regression): avoid calling `useQuery` `onCompleted` for cache writes (#10229)

alessbell
authored and
jerelmiller
committed
Write the first failing test for useSuspenseQuery
jerelmiller
committed
Add extremely basic implementation to get a suspense query working
jerelmiller
committed
Use MockedProvider for test
jerelmiller
committed
Add jest-dom for tests
jerelmiller
committed
Use toBeInTheDocument matcher for suspense query
jerelmiller
committed
Minor tweak to test name
jerelmiller
committed
Rename useSuspenseQuery to useSuspenseQuery_experimental
jerelmiller
committed
Export useSuspenseQuery
jerelmiller
committed
Add test to validate suspense works with variables
jerelmiller
committed
Limit result to data and variables for now
jerelmiller
committed
Skip useSuspenseQuery TODO tests
jerelmiller
committed
Add check to verify document type
jerelmiller
committed
Add a suspense cache and ensure it checks for it
jerelmiller
committed
Add suspenseCache to MockedProvider
jerelmiller
committed
Add ability to resuspend when a query changes variables
jerelmiller
committed
Add a test to verify same variables returns same results
jerelmiller
committed
Minor tweak to order of tests
jerelmiller
committed
Rework suspense cache and implementation a bit
jerelmiller
committed
Add ability to skip suspense when variables change
jerelmiller
committed
Use patch-package to add renderHook to @testing-library/react-12
jerelmiller
committed
Use renderHook exported from @testing-library/react
jerelmiller
committed
Rewrite useSuspenseQuery tests with renderHook
jerelmiller
committed
Update suspense query options to a more limited set
jerelmiller
committed
Limit the fetch policies available for useSuspenseQuery
jerelmiller
committed
Update tests to check component resuspends when changing variables for all fetch policies
jerelmiller
committed
Create a helper to render base case hook
jerelmiller
committed
Add prettier and config but only for a few files
jerelmiller
committed
Run prettier on allowed files
jerelmiller
committed
Pin prettier to exact version
jerelmiller
committed
Add test to validate fetch is called correct number of times
jerelmiller
committed
Ensure changing variables suspends properly
jerelmiller
committed
Remove sanity check test
jerelmiller
committed
Minor adjustments to tests
jerelmiller
committed
Add ability to re-suspend when changing queries
jerelmiller
committed
Update name of test to better reflect what its testing
jerelmiller
committed
Remove auto test setup for all fetch policies
jerelmiller
committed
Add validation to ensure support fetch policy is used
jerelmiller
committed
Ensure default fetch policy is used for validation
jerelmiller
committed
Simpler test to better focus on its purpose
jerelmiller
committed
Better type for renderSuspenseHook
jerelmiller
committed
Add missing DEFAULT_FETCH_POLICY constant
jerelmiller
committed
Fix type of previous opts ref
jerelmiller
committed
Fix incorrect test assertion
jerelmiller
committed
Minor change to order of tests
jerelmiller
committed
Add test to ensure referential equality is maintained
jerelmiller
committed
Add test to validate observable is torn down on unmount
jerelmiller
committed
Ensure suspense cache removes observable when town down
jerelmiller
committed
Add test to validate suspense cache keeps query if used by others
jerelmiller
committed
Ensure useSuspenseQuery works properly with network-only fetch policy
jerelmiller
committed
Refactor tests to move some of the common test setup into own functions
jerelmiller
committed
Add tests to verify no-cache fetch policy works correctly
jerelmiller
committed
Add tests to validate cache-and-network fetch policy works correctly
jerelmiller
committed
Don't support standby fetch policy for now
jerelmiller
committed
Add test to verify client can be overridden
jerelmiller
committed
Add tests to verify cache is written properly
jerelmiller
committed
Handle when to suspend based on fetch policy and data in the cache
jerelmiller
committed
Rename opts to watchQueryOptions and use better type
jerelmiller
committed
More robust test for checking overridden client
jerelmiller
committed
More robust way to check how many times a component suspended
jerelmiller
committed
Add ability to only suspend on initial fetch
jerelmiller
committed
Add missing imports and missed rename
jerelmiller
committed
Add test to verify no-cache maintains result on rerender
jerelmiller
committed
Use fetch policy from client default options if available
jerelmiller
committed
Ensure SuspensePolicy type is exported from types
jerelmiller
committed
Add ability to use default variables from client
jerelmiller
committed
Remove unnecessary console.log
jerelmiller
committed
Simplify test that uses custom wrapper
jerelmiller
committed
Add test and implementation to merge global and local variables
jerelmiller
committed
Add implementation to make sure variables can be removed
jerelmiller
committed
Add check to ensure useSuspenseQuery suspends immediately
jerelmiller
committed
Add check to ensure suspense cache is defined
jerelmiller
committed
Minor tweak to test name
jerelmiller
committed
Add tests to ensure useSuspenseQuery responds to cache updates
jerelmiller
committed
Add test to ensure context is pased to link chain
jerelmiller
committed
Throw errors when the result is an error
jerelmiller
committed
Add react-error-boundary for tests
jerelmiller
committed
Add support for ignore and none error policies
jerelmiller
committed
Better test setup to distinguish between network errors and graphql errors
jerelmiller
committed
Add implementation to work with errorPolicy = "all"
jerelmiller
committed
Handle GraphQL errors with all error policies
jerelmiller
committed
Add error to result checked in tests
jerelmiller
committed
Add tests to ensure partial data results are returned with errors
jerelmiller
committed
Add test to ensure error is persisted between renders
jerelmiller
committed
Add tests to ensure multiple GraphQL errors are handled
jerelmiller
committed
Add test to ensure errors are removed when changing variables
jerelmiller
committed
Add test to ensure canonizeResults works as expected
jerelmiller
committed
Bump wait time to help with flaky test
jerelmiller
committed
Add ability to return partial result data from the cache
jerelmiller
committed
Add additional supported options to suspense query hook type
jerelmiller
committed
Refactor to use it.each to reduce duplication of some tests
jerelmiller
committed
Use client.writeQuery in test since its more synchronous
jerelmiller
committed
Switch to toMatchObject expectation to check subset of return value
jerelmiller
committed
Implement refetch ability with useSuspenseQuery
jerelmiller
committed
Minor tweaks to test setup
jerelmiller
committed
Add implementation to throw an error after refetch returns error
jerelmiller
committed
Add tests to check error behavior when calling refetch
jerelmiller
committed
Add test to validate partial data results for refetch
jerelmiller
committed
Add support for fetchMore with useSuspenseQuery
jerelmiller
committed
Add test to validate nextFetchPolicy is applied after initial suspense
jerelmiller
committed
Add tests to verify refetchWritePolicy is honored
jerelmiller
committed
Add test verifying observable is unsubscribed properly
jerelmiller
committed
Ignore useSuspenseQuery tests in React 17
jerelmiller
committed
Ensure TVariables is passed to TypedDocumentNode in getQuery
jerelmiller
committed
Rename resolved property to fulfilled
jerelmiller
committed
Check to ensure result for same variables is the same object
jerelmiller
committed
Add test to validate multiple refetches result in suspensions
jerelmiller
committed
Allow suspenseCache in renderSuspenseHook helper
jerelmiller
committed
Add check of render count on multiple refetch
jerelmiller
committed
Fix issue where a component was rendered before the promise resolved
jerelmiller
committed
Remove variables from the result of useSuspenseQuery
jerelmiller
committed
Fix missing import
jerelmiller
committed
Always run validations in dev
jerelmiller
committed
Add test to verify observable not over subscribed
jerelmiller
committed
Add fix for rejected promise causing issue with test
jerelmiller
committed
Simplify suspense cache entry
jerelmiller
committed
Wrap refetch/fetchMore in act to remove warnings
jerelmiller
committed
Use destructured values in useEffect
jerelmiller
committed
Refactor useDeepMemo into its own hook file
jerelmiller
committed
Add tests for useDeepMemo
jerelmiller
committed
Remove unused import
jerelmiller
committed
Simplify condition for setting network status
jerelmiller
committed
Use entire watchQueryOptions in useEffect since its used
jerelmiller
committed
Rename ref for clarity
jerelmiller
committed
Extract custom hook for checking whether component is suspended
jerelmiller
committed
Extract custom hook to get watch query options
jerelmiller
committed
Remove old logic for checking suspended ref
jerelmiller
committed
Move validation to useWatchQueryOptions
jerelmiller
committed
Use destructured value
jerelmiller
committed
Update API for suspense cache
jerelmiller
committed
Consolidate subscription handlers since they are the same implementation
jerelmiller
committed
Use variable when deleting entry from the suspense cache
jerelmiller
committed
Fix issue where fetchPolicy was overwritten when using nextFetchPolicy and changing variables
jerelmiller
committed
Move logic of getting result from observable into own hook
jerelmiller
committed
Rename isSuspendedRef to isMountedRef for better clarity
jerelmiller
committed
Use variable to reduce typing
jerelmiller
committed
Always remove previous query/variables from suspense cache when they change
jerelmiller
committed
Combine effects to remove suspense cache entries
jerelmiller
committed
Fix regression on removing cache entry too soon
jerelmiller
committed
Allow prettier to work on internal hooks
jerelmiller
committed
Add test to ensure no network request for cache-first
jerelmiller
committed
Refactor logic for determining when to suspend
jerelmiller
committed
Update bundle size
jerelmiller
committed
Update snapshot test
jerelmiller
committed
Fix typos in prettierignore
jerelmiller
committed
Remove the check for parent suspense cache in ApolloProvider
jerelmiller
committed
Warn when using no-cache fetch policy with returnPartialData
jerelmiller
committed
Add test to ensure cache-first suspends with partial data
jerelmiller
committed
Add additional variable to better show intent of logic
jerelmiller
committed
Add option to watchQuery that disables fetch on the first subscription
jerelmiller
committed
Make useSuspenseQuery more robust by removing some patch cases by setting fetchOnFirstSubscribe to false
jerelmiller
committed
Add comment explaining use of fetchOnFirstSubscribe
jerelmiller
committed
Move promise inline
jerelmiller
committed
Add changeset
jerelmiller
committed
Update bundlesize
jerelmiller
committed
Update package-lock.json
jerelmiller
committed

Commits on Dec 9, 2022

Fix typos in test comments
jerelmiller
committed
Remove inaccurate comment
jerelmiller
committed
Pin patch-package to a specific version
jerelmiller
committed

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Community
Docs
Contact

You can’t perform that action at this time.