Improve cache search #1056
Merged
Improve cache search #1056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessbell
approved these changes
Sep 5, 2023
Contributor
alessbell
left a comment
alessbell
left a comment
There was a problem hiding this comment.
This is such a great usability improvement! 🚀
Member
Author
|
Will merge once #1052 is merged since this branches off of that 🙂 |
Contributor
|
Just noticed that :) Was hoping I could sneak this into the next release I'm about to cut but can't review the other one before signing off today 😅 |
jerelmiller
force-pushed
the
better-search
branch
from
7a7fabb to
049eef5
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Searching the cache in the devtools has always felt a little bit broken. At present, it doesn't do any filtering of the list, so matches against the search string are very difficult to find if the list of cache keys is large (see example in this discussion). Furthermore, it would match against values in the cache entry itself, but this was difficult to find since it required you to activate the cache entry to see it.
This PR improves the search functionality by matching only against cache keys and actively filtering that list as the user types. The matched string in the cache key is also now highlighted so its obvious how the record is filtered. This should improve cases where you might have an ID and want to quickly see what what a record with that ID contains by pasting that ID into the search field.
Before
After
