Merged
Conversation
dosubot
bot
added
the
size:XS
Contributor
WalkthroughThe documentation was updated to correct several URLs, redirecting references from the old Apollo repository to the new apollo-java repository for Java SDK source code and test example links. No functional or logical documentation content was changed; only the URLs were modified. Changes
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/zh/client/java-sdk-user-guide.md(2 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: youngzil
PR: apolloconfig/apollo#5262
File: docs/en/client/java-sdk-user-guide.md:1108-1112
Timestamp: 2024-10-26T15:04:39.631Z
Learning: In `docs/en/client/java-sdk-user-guide.md`, the Eureka client configuration properties such as `eureka.client.serviceUrl.defaultZone`, `eureka.client.healthcheck.enabled`, `eureka.client.registerWithEureka`, `eureka.client.fetchRegistry`, and `eureka.client.eurekaServiceUrlPollIntervalSeconds` cannot be changed to kebab-case and must remain in their original camelCase form.
Learnt from: youngzil
PR: apolloconfig/apollo#5262
File: docs/zh/client/java-sdk-user-guide.md:1054-1060
Timestamp: 2024-10-26T14:54:04.074Z
Learning: Within the `application.properties` file in `docs/zh/client/java-sdk-user-guide.md`, the `eureka.client.serviceUrl.defaultZone` and related Eureka client properties should remain in their existing camelCase format and should not be converted to kebab-case, as they cannot be changed.
docs/zh/client/java-sdk-user-guide.md (2)
Learnt from: youngzil
PR: apolloconfig/apollo#5262
File: docs/en/client/java-sdk-user-guide.md:1108-1112
Timestamp: 2024-10-26T15:04:39.631Z
Learning: In `docs/en/client/java-sdk-user-guide.md`, the Eureka client configuration properties such as `eureka.client.serviceUrl.defaultZone`, `eureka.client.healthcheck.enabled`, `eureka.client.registerWithEureka`, `eureka.client.fetchRegistry`, and `eureka.client.eurekaServiceUrlPollIntervalSeconds` cannot be changed to kebab-case and must remain in their original camelCase form.
Learnt from: youngzil
PR: apolloconfig/apollo#5262
File: docs/zh/client/java-sdk-user-guide.md:1054-1060
Timestamp: 2024-10-26T14:54:04.074Z
Learning: Within the `application.properties` file in `docs/zh/client/java-sdk-user-guide.md`, the `eureka.client.serviceUrl.defaultZone` and related Eureka client properties should remain in their existing camelCase format and should not be converted to kebab-case, as they cannot be changed.
🪛 markdownlint-cli2 (0.17.2)
docs/zh/client/java-sdk-user-guide.md
1377-1377: Bare URL used
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build (8)
🔇 Additional comments (2)
docs/zh/client/java-sdk-user-guide.md (2)
108-108: URL update looks good链接已正确指向
apollo-java仓库中的MetaServerProvider.java，语法无误。
116-116: Both reference links resolve correctly
LegacyMetaServerProvider与DefaultMetaServerProvider的新 URL 均指向apollo-java仓库且格式正确。
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
nobodyiam
force-pushed
the
fix-java-sdk-doc
branch
from
6a35fa4 to
4e09819
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
XXXXX
Which issue(s) this PR fixes:
Fixes #
Brief changelog
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.CHANGESlog.Summary by CodeRabbit