docs: openapi 3.2.17 Create App And grant administrative privileges#5046
Merged
nobodyiam merged 7 commits intoapolloconfig:masterfrom Dec 22, 2023
Merged
docs: openapi 3.2.17 Create App And grant administrative privileges#5046nobodyiam merged 7 commits intoapolloconfig:masterfrom
nobodyiam merged 7 commits intoapolloconfig:masterfrom
Conversation
dosubot
bot
added
the
size:M
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5046 +/- ##
============================================
+ Coverage 49.62% 49.66% +0.03%
- Complexity 1904 1906 +2
============================================
Files 372 372
Lines 11558 11558
Branches 1127 1127
============================================
+ Hits 5736 5740 +4
+ Misses 5482 5478 -4
Partials 340 340 ☔ View full report in Codecov by Sentry. |
nobodyiam
force-pushed
the
docs/openapi-create-app
branch
from
32d33b8 to
84600a1
Compare
nobodyiam
reviewed
Dec 17, 2023
|
|
||
| App can be created through this interface, | ||
|
|
||
| > note: 需要在创建第三方应用时，**勾选允许创建app，否则会触发异常，HTTP状态码401** |
Member
There was a problem hiding this comment.
Suggested change
| > note: 需要在创建第三方应用时，**勾选允许创建app，否则会触发异常，HTTP状态码401** |
Should this line be deleted?
Contributor
Author
There was a problem hiding this comment.
I think we need to prompt user, some users maybe use 'old token' to call this openapi method and get the failed result.
Member
There was a problem hiding this comment.
I concur. My suggestion is to remove the line in Chinese since it's already duplicated in English below.
Contributor
Author
There was a problem hiding this comment.
My fault. Remove it already.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
Add document of openapi app creation.
Which issue(s) this PR fixes:
Fixes #4954 (comment)
Brief changelog
3.2.17 Create App And grant administrative privileges
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.CHANGESlog.