apollo assembly optimization #5035
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...ice/src/main/java/com/ctrip/framework/apollo/adminservice/AdminServiceAutoConfiguration.java
Fixed
Show fixed
Hide fixed
|
Wow! This pr is truly thrilling! |
dosubot
bot
added
the
size:XXL
nobodyiam
left a comment
nobodyiam
left a comment
There was a problem hiding this comment.
Now the whole apollo servers could be launched in one process, this is amazing!
Would you please also update the apollo-development-guide.md?
...ice/src/main/java/com/ctrip/framework/apollo/adminservice/AdminServiceAutoConfiguration.java
Outdated
Show resolved
Hide resolved
apollo-assembly/src/main/resources/application-github.properties
Outdated
Show resolved
Hide resolved
| No configuration is required, just use the following command to start | ||
| > Note: When using the in-memory database, any operation will be lost after the Apollo process restarts | ||
| ```bash | ||
| export SPRING_PROFILES_ACTIVE="github,auth" |
There was a problem hiding this comment.
Is it feasible to enhance the demo.sh script to enable users to initiate the quick-start demonstration efficiently through some configuration settings?
|
It appears there is some incompatibility with database-discovery. When I execute the assembly using the spring profiles
|
# Conflicts: # scripts/sql/apolloconfigdb.sql # scripts/sql/apolloportaldb.sql
|
|
||
| @Override | ||
| protected void configure(HttpSecurity http) throws Exception { | ||
| http.csrf().disable(); |
Check failure
Code scanning / CodeQL
Disabled Spring CSRF protection
|
This pull request appears to be in good shape now. Could you also update the CHANGES.md file? Since this constitutes a major change, it's important to document it there. |
|
BTW, #5072 was merged with a schema change, would you please help to update the code base again? |
nobodyiam
left a comment
nobodyiam
left a comment
There was a problem hiding this comment.
Please also fix the failed tests.
2024-01-26T16:03:31.8898714Z Caused by: java.lang.IllegalStateException: @order on WebSecurityConfigurers must be unique. Order of 99 was already used on com.ctrip.framework.apollo.adminservice.controller.TestWebSecurityConfig$$EnhancerBySpringCGLIB$$ac5b1e3@469959b6, so it cannot be used on com.ctrip.framework.apollo.adminservice.AdminServiceAssemblyConfiguration$AdminServiceSecurityConfigurer$$EnhancerBySpringCGLIB$$8154145d@270147e3 too.
# Conflicts: # docs/en/contribution/apollo-development-guide.md # docs/zh/contribution/apollo-development-guide.md
2 participants
What's the purpose of this PR
Which issue(s) this PR fixes:
#4313
#4729
Brief changelog
TablePrefixNamingStrategyto match the table name prefixFollow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.CHANGESlog.