[Multi-Database Support][h2] Support run on h2#4851
Merged
nobodyiam merged 4 commits intoapolloconfig:masterfrom May 6, 2023
Merged
[Multi-Database Support][h2] Support run on h2#4851nobodyiam merged 4 commits intoapolloconfig:masterfrom
nobodyiam merged 4 commits intoapolloconfig:masterfrom
Conversation
Member
|
Hello, I am a serverless review bot on flows.network. Here are my reviews of code commits in this PR. Commit 1This patch adds support for the h2 database to Apollo. It does this by adding an h2 initialization script, an annotation for running the script and a datasource field. The h2 initialization script makes changes to the ServerConfig table by adding a new row. There are no apparent potential problems with this patch. |
1bf1e97 to
2a483be
Compare
Member
|
review again |
Member
|
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR. |
2a483be to
56797af
Compare
56797af to
67b4472
Compare
Codecov Report
@@ Coverage Diff @@
## master #4851 +/- ##
============================================
+ Coverage 48.36% 48.46% +0.09%
- Complexity 1722 1725 +3
============================================
Files 346 346
Lines 10827 10835 +8
Branches 1078 1080 +2
============================================
+ Hits 5237 5251 +14
+ Misses 5268 5260 -8
- Partials 322 324 +2
|
nobodyiam
requested changes
May 6, 2023
apollo-biz/src/main/java/com/ctrip/framework/apollo/biz/service/BizDBPropertySource.java
Outdated
Show resolved
Hide resolved
...o-portal/src/main/java/com/ctrip/framework/apollo/portal/service/PortalDBPropertySource.java
Outdated
Show resolved
Hide resolved
This was referenced May 6, 2023
Open
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
Added support for h2 init sql to ApolloConfig. Verified the following functionalities: adding/disabling/enabling users, adding/deleting namespaces, publishing configurations, and adding applications.
Brief changelog
Add h2 init sql, only effective when h2
How to use it
apollo-config run args
apollo-portal run args
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.CHANGESlog.