Remove the usage of Env.name() using Env.getName()#4816
Merged
nobodyiam merged 1 commit intoapolloconfig:masterfrom Mar 28, 2023
Merged
Remove the usage of Env.name() using Env.getName()#4816nobodyiam merged 1 commit intoapolloconfig:masterfrom
nobodyiam merged 1 commit intoapolloconfig:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4816 +/- ##
============================================
- Coverage 48.26% 48.26% -0.01%
+ Complexity 1722 1721 -1
============================================
Files 346 346
Lines 10778 10777 -1
Branches 1075 1075
============================================
- Hits 5202 5201 -1
Misses 5254 5254
Partials 322 322
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
nobodyiam
force-pushed
the
remove-the-usage-getname
branch
from
a9b191a to
66e06ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
Rmove the deprecated method, and delete it. If an internal method has been deprecated for a significant period of time, it may be preferable to remove it. If necessary, we can easily restore it using git.
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.