Optimising ServiceRegistry creation SQL#4792
Merged
nobodyiam merged 76 commits intoapolloconfig:masterfrom Mar 14, 2023
Merged
Conversation
# Conflicts: # README.md
Codecov Report
@@ Coverage Diff @@
## master #4792 +/- ##
============================================
+ Coverage 47.21% 47.25% +0.03%
- Complexity 1658 1660 +2
============================================
Files 346 346
Lines 10683 10683
Branches 1063 1063
============================================
+ Hits 5044 5048 +4
+ Misses 5331 5327 -4
Partials 308 308 see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Member
|
As this only affects some MySQL versions when first installing or upgrading, I think it's ok not to release a patch version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
here are the relevant questions:
https://stackoverflow.com/questions/9192027/invalid-default-value-for-create-date-timestamp-field