add version notice for other service registry support#4786
Merged
Anilople merged 2 commits intoapolloconfig:masterfrom Mar 17, 2023
Merged
add version notice for other service registry support#4786Anilople merged 2 commits intoapolloconfig:masterfrom
Anilople merged 2 commits intoapolloconfig:masterfrom
Conversation
hezhangjian
previously approved these changes
Mar 10, 2023
Codecov Report
@@ Coverage Diff @@
## master #4786 +/- ##
============================================
- Coverage 47.33% 47.22% -0.11%
+ Complexity 1662 1659 -3
============================================
Files 346 346
Lines 10684 10683 -1
Branches 1064 1063 -1
============================================
- Hits 5057 5045 -12
- Misses 5319 5331 +12
+ Partials 308 307 -1 see 6 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Anilople
approved these changes
Mar 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
add version notice for other service registry support
Which issue(s) this PR fixes:
Fixes #4779
Brief changelog
add version notice for nacos-discovery/consul-discovery/zookeeper-discovery/custom-defined-discovery respectively.
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.CHANGESlog.