[Multi-Database Support] Without Reliance on boolean integer compare#4757
Merged
nobodyiam merged 1 commit intoapolloconfig:masterfrom Mar 1, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4757 +/- ##
=========================================
Coverage 47.27% 47.27%
Complexity 1655 1655
=========================================
Files 346 346
Lines 10662 10662
Branches 1058 1058
=========================================
Hits 5040 5040
Misses 5316 5316
Partials 306 306
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
Comparing INTEGER type to BOOLEAN type is not supported by h2 database. We should avoid using this feature.
Tested on my laptop.
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.CHANGESlog.