Fix apolloconfigdb.sql apolloportaldb.sql AppId length settings are inconsistent#4725
Merged
nobodyiam merged 13 commits intoapolloconfig:masterfrom Feb 11, 2023
Merged
Fix apolloconfigdb.sql apolloportaldb.sql AppId length settings are inconsistent#4725nobodyiam merged 13 commits intoapolloconfig:masterfrom
nobodyiam merged 13 commits intoapolloconfig:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4725 +/- ##
=========================================
Coverage 47.22% 47.22%
Complexity 1661 1661
=========================================
Files 349 349
Lines 10691 10691
Branches 1062 1062
=========================================
Hits 5049 5049
- Misses 5334 5335 +1
+ Partials 308 307 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
nisiyong
reviewed
Feb 8, 2023
nobodyiam
requested changes
Feb 9, 2023
Contributor
Author
|
I have updated the relevant question, please review it for me. |
nobodyiam
reviewed
Feb 10, 2023
nobodyiam
reviewed
Feb 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
When I initialized the database script, I found that the size of the
AppIdfield in each table was inconsistent. I think it needs a uniform size of varchar 64.For example, AppId is the logical foreign key of the database table AppNamespace. The size of AppId needs to be consistent and should be set to 64. Why not 500? Because when I try to put the UNIQUE index on the AppId VARCHAR(500) field, it will prompt
the specified key was too long; max key length is 767 bytes, in theutf8mb4character set mode, the field length should be less than 191.And the front-end page design has made a check that the length cannot be greater than 64。
So I think the size of appId should be set to varchar 64.
According to the database script information, the database
Apptable sets the size ofAppIdto500.According to the database script information, the database
AppNamespacetable sets the size ofAppIdto64.Brief changelog
Follow this checklist to help us incorporate your contribution quickly and easily:
CHANGESlog.