Fix the problem of deleting blank items appear at the end#4654#4662
Merged
nobodyiam merged 3 commits intoapolloconfig:masterfrom Nov 30, 2022
Merged
Fix the problem of deleting blank items appear at the end#4654#4662nobodyiam merged 3 commits intoapolloconfig:masterfrom
nobodyiam merged 3 commits intoapolloconfig:masterfrom
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Codecov Report
@@ Coverage Diff @@
## master #4662 +/- ##
============================================
- Coverage 47.21% 47.12% -0.09%
+ Complexity 1649 1648 -1
============================================
Files 347 347
Lines 10643 10643
Branches 1057 1057
============================================
- Hits 5025 5016 -9
- Misses 5314 5323 +9
Partials 304 304
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
Author
|
@nobodyiam I recommit the change, please help me review the code again. |
Contributor
Author
|
@lepdou thanks |
Member
|
The code change looks good to me. Would you please help to update the CHANGES.md? |
Contributor
Author
create request to update CHANGES.md? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
Fix the problem of deleting blank items appear at the end.
Which issue(s) this PR fixes:
Fixes #4654
Brief changelog
1.delete blank item then it'll appear at the end


XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.CHANGESlog.