feature:support non-properties-diff#4533
Merged
lepdou merged 6 commits intoapolloconfig:masterfrom Aug 31, 2022
Merged
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA. |
Contributor
Author
|
I record a video for this feature, and please criticize and correct me, thank you very much! QQ.20220823234052.mp4 |
Contributor
|
@SunnyBoy-WYH |
Codecov Report
@@ Coverage Diff @@
## master #4533 +/- ##
=========================================
Coverage 53.41% 53.41%
Complexity 2708 2708
=========================================
Files 492 492
Lines 15390 15390
Branches 1596 1596
=========================================
Hits 8220 8220
Misses 6611 6611
Partials 559 559 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
lepdou
reviewed
Aug 29, 2022
| </div> | ||
| <div class="radio-inline"> | ||
| <label > | ||
| <input type="radio" name="tableDiff" ng-click="isTableDiff = false" ng-checked="isTableDiff == false"> |
Contributor
There was a problem hiding this comment.
It can be simplified to?
ng-checked="!isTableDiff"
apollo-portal/src/main/resources/static/scripts/controller/config/DiffConfigController.js
Outdated
Show resolved
Hide resolved
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What's the purpose of this PR
feature: support diff config for non-properties type files.
Which issue(s) this PR fixes:
Fixes #
link:#4315
Brief changelog