1、fix transcation invalid

[ksice]

What's the purpose of this PR

Fix transaction invalid

sonar prompt bug is "assignNamespaceRoleToConsumer's" @transactional requirement is incompatible with the one for this method.

Follow this checklist to help us incorporate your contribution quickly and easily:

• Read the Contributing Guide before making this pull request.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Write necessary unit tests to verify the code.
• Run mvn clean test to make sure this pull request doesn't break anything.
• Update the CHANGES log.

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[ksice]

I have read the CLA Document and I hereby sign the CLA

[nobodyiam]

Thanks for the pull request. However, I'd like to learn more about what this change solves. Since there is no checked exception thrown for method assignNamespaceRoleToConsumer, I think adding rollbackFor or not is the same?

[ksice]

Thanks for the pull request. However, I'd like to learn more about what this change solves. Since there is no checked exception thrown for method assignNamespaceRoleToConsumer, I think adding rollbackFor or not is the same?

I think rollbackfor can not be added but the @transcation annotation should be added, otherwise the transaction of the "assignNamespace" method will be invalidated

[nobodyiam]

Yes, but I think the @Transactional annotation is already added to public List<ConsumerRole> assignNamespaceRoleToConsumer(String token, String appId, String namespaceName, String env)?

[ksice]

Yes, but I think the @Transactional annotation is already added to public List<ConsumerRole> assignNamespaceRoleToConsumer(String token, String appId, String namespaceName, String env)?

yes,But what I mean is that this method assignNamespaceRoleToConsumer(String token, String appId, String namespaceName) needs to add @Transactional, @Transactional has several failure scenarios, one of which is
The @Transactional annotation does not take effect in similar method calls, so when assignNamespaceRoleToConsumer(String token, String appId, String namespaceName) is called, it will cause assignNamespaceRoleToConsumer(String token, String appId, String namespaceName, String env)
@Transactional fails, I find it not roll back when I locally called assignNamespaceRoleToConsumer(String token, String appId, String namespaceName) to throw an exception。
E.g

[nobodyiam]

OK, then I think it's reasonable to add @Transactional to assignNamespaceRoleToConsumer(String token, String appId, String namespaceName).

[ksice]

OK, then I think it's reasonable to add @Transactional to assignNamespaceRoleToConsumer(String token, String appId, String namespaceName).

ok, I modified the commit

[nobodyiam]

LGTM