add an option to custom oidc userDisplayName#4507
Merged
nobodyiam merged 10 commits intoapolloconfig:masterfrom Sep 9, 2022
Merged
add an option to custom oidc userDisplayName#4507nobodyiam merged 10 commits intoapolloconfig:masterfrom
nobodyiam merged 10 commits intoapolloconfig:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4507 +/- ##
============================================
- Coverage 53.47% 53.36% -0.11%
+ Complexity 2707 2704 -3
============================================
Files 492 494 +2
Lines 15393 15419 +26
Branches 1595 1598 +3
============================================
- Hits 8231 8228 -3
- Misses 6605 6634 +29
Partials 557 557
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Member
|
Looks great! Shall we also add some instructions in the oidc related documents? |
nobodyiam
reviewed
Aug 15, 2022
docs/zh/development/portal-how-to-implement-user-login-function.md
Outdated
Show resolved
Hide resolved
Member
|
Looks great, would you please also help to update the en doc? |
# Conflicts: # CHANGES.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
add an option for custom oidc userDisplayName claimName
Which issue(s) this PR fixes:
Fixes #3795 #4498
Brief changelog
spring.security.oidc.user-display-name-claim-nameto custom the claimName of the userDisplayNamegetFullNameas a fallback of thegetPreferredUsernameFollow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.CHANGESlog.