Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4493 +/- ##
=========================================
Coverage 53.45% 53.45%
- Complexity 2701 2702 +1
=========================================
Files 490 490
Lines 15344 15345 +1
Branches 1596 1598 +2
=========================================
+ Hits 8202 8203 +1
- Misses 6584 6585 +1
+ Partials 558 557 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mghio
reviewed
Jul 30, 2022
apollo-common/src/main/java/com/ctrip/framework/apollo/common/entity/BaseEntity.java
Outdated
Show resolved
Hide resolved
klboke
previously approved these changes
Aug 1, 2022
nisiyong
reviewed
Aug 1, 2022
apollo-common/src/main/java/com/ctrip/framework/apollo/common/entity/BaseEntity.java
Show resolved
Hide resolved
apollo-common/src/main/java/com/ctrip/framework/apollo/common/entity/BaseEntity.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
Fix the deleted at timestamp field is set for records not deleted.
Which issue(s) this PR fixes:
Fixes #4492
Brief changelog
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.CHANGESlog.