Optimize Spring-Security Firewall Deny Request Response 400#4428
Merged
nobodyiam merged 35 commits intoapolloconfig:masterfrom Jun 28, 2022
Merged
Optimize Spring-Security Firewall Deny Request Response 400#4428nobodyiam merged 35 commits intoapolloconfig:masterfrom
nobodyiam merged 35 commits intoapolloconfig:masterfrom
Conversation
# Conflicts: # README.md
Codecov Report
@@ Coverage Diff @@
## master #4428 +/- ##
============================================
- Coverage 53.42% 53.42% -0.01%
Complexity 2688 2688
============================================
Files 490 490
Lines 15254 15255 +1
Branches 1586 1586
============================================
Hits 8150 8150
- Misses 6548 6549 +1
Partials 556 556
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
Requesting a service using a non-compliant URL specification returns 500 and the server side reports an exception, e.g.
Return 400 , e.g.
This scenario is more appropriate to use Bad Request (400), in our production environment, because of this problem, the gateway layer alerts often misreported Apollo Server exceptions