use item.isDeleted to check whether the item is deleted#4279
Merged
nobodyiam merged 1 commit intoapolloconfig:masterfrom Mar 27, 2022
Merged
use item.isDeleted to check whether the item is deleted#4279nobodyiam merged 1 commit intoapolloconfig:masterfrom
nobodyiam merged 1 commit intoapolloconfig:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4279 +/- ##
============================================
+ Coverage 52.56% 52.59% +0.03%
- Complexity 2641 2642 +1
============================================
Files 488 488
Lines 15253 15253
Branches 1577 1577
============================================
+ Hits 8017 8022 +5
+ Misses 6685 6681 -4
+ Partials 551 550 -1
Continue to review full report at Codecov.
|
zouyx
approved these changes
Mar 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
Use
item.isDeletedto check whether the item is deleted, asitem.dataChangeLastModifiedByis not null for deleted items since #2680.Which issue(s) this PR fixes:
Fixes #4276
Brief changelog
item.isDeletedto check whether the item is deletedFollow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.CHANGESlog.