Using commons-lang3 to replace commons-lang#4225
Merged
nobodyiam merged 3 commits intoapolloconfig:masterfrom Feb 15, 2022
Merged
Using commons-lang3 to replace commons-lang#4225nobodyiam merged 3 commits intoapolloconfig:masterfrom
nobodyiam merged 3 commits intoapolloconfig:masterfrom
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
09f032d to
59a7ec7
Compare
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
nobodyiam
requested changes
Feb 13, 2022
Member
nobodyiam
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
I think it's okay to upgrade commons-lang to commons-lang3 for apollo servers but it seems to me unnecessary to add an extra dependency to apollo-core which will impact a lot of users.
apollo-core/src/main/java/com/ctrip/framework/foundation/internals/Utils.java
Show resolved
Hide resolved
apollo-core/src/test/java/com/ctrip/framework/foundation/internals/UtilsTest.java
Show resolved
Hide resolved
82d47d6 to
e5a2763
Compare
nobodyiam
reviewed
Feb 14, 2022
apollo-core/src/test/java/com/ctrip/framework/foundation/internals/UtilsTest.java
Outdated
Show resolved
Hide resolved
8a8d1f3 to
ee7d9f7
Compare
ee7d9f7 to
8af33cf
Compare
Codecov Report
@@ Coverage Diff @@
## master #4225 +/- ##
============================================
- Coverage 52.58% 52.56% -0.02%
- Complexity 2631 2632 +1
============================================
Files 486 486
Lines 15226 15226
Branches 1573 1573
============================================
- Hits 8006 8003 -3
- Misses 6664 6668 +4
+ Partials 556 555 -1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
commons-lang3rather thancommons-lang, sincecommons-langis deprecated.org.apache.commons.lang3.SystemUtilsto judge the system, this utils is more reliable.Which issue(s) this PR fixes:
no
Brief changelog
commons-lang3to replacecommons-langorg.apache.commons.lang3.SystemUtilsto judge is Window.Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.CHANGESlog.