Provider Interface Support SPI & Optimize ProviderManager SPI#4218
Merged
nobodyiam merged 7 commits intoapolloconfig:masterfrom Jan 29, 2022
Merged
Provider Interface Support SPI & Optimize ProviderManager SPI#4218nobodyiam merged 7 commits intoapolloconfig:masterfrom
Provider Interface Support SPI & Optimize ProviderManager SPI#4218nobodyiam merged 7 commits intoapolloconfig:masterfrom
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Provider Interface Support SPI & Optimize ProviderManager SPI
nobodyiam
requested changes
Jan 26, 2022
apollo-core/src/main/java/com/ctrip/framework/foundation/internals/DefaultProviderManager.java
Outdated
Show resolved
Hide resolved
apollo-core/src/main/java/com/ctrip/framework/foundation/spi/ProviderManager.java
Show resolved
Hide resolved
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
….spi.ProviderManager.getOrder`
nobodyiam
reviewed
Jan 27, 2022
apollo-core/src/main/java/com/ctrip/framework/foundation/internals/DefaultProviderManager.java
Outdated
Show resolved
Hide resolved
apollo-core/src/main/java/com/ctrip/framework/foundation/internals/DefaultProviderManager.java
Outdated
Show resolved
Hide resolved
apollo-core/src/main/java/com/ctrip/framework/foundation/internals/NullProviderManager.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
updated |
Codecov Report
@@ Coverage Diff @@
## master #4218 +/- ##
=========================================
Coverage 52.58% 52.58%
- Complexity 2631 2632 +1
=========================================
Files 485 486 +1
Lines 15225 15226 +1
Branches 1573 1573
=========================================
+ Hits 8006 8007 +1
- Misses 6663 6664 +1
+ Partials 556 555 -1
Continue to review full report at Codecov.
|
nobodyiam
reviewed
Jan 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
ApplicationProviderNetworkProviderinDefaultProviderManagerOrderedinProviderManagerand useServiceBootstrap.loadPrimaryinstead ofcom.ctrip.framework.foundation.internals.ServiceBootstrap#loadFirst. BecausegetManagermethod in classFoundationusecom.ctrip.framework.foundation.internals.ServiceBootstrap#loadFirstto load interfaceProviderManagerimplementation, if I want to define my ownProviderManager, which class has higher priority can not spefic.Brief changelo
Provider Interface Support SPI & Optimize ProviderManager SPI
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.CHANGESlog.