Skip to content

The release history of namespaces that are not properties will also show comments and release times#4198

Merged
nobodyiam merged 28 commits intoapolloconfig:masterfrom
klboke:release-history
Jan 11, 2022
Merged

The release history of namespaces that are not properties will also show comments and release times#4198
nobodyiam merged 28 commits intoapolloconfig:masterfrom
klboke:release-history

Conversation

@klboke
Copy link
Contributor

@klboke klboke commented Jan 7, 2022

What's the purpose of this PR

  • The release history of namespaces that are not properties will also show comments and release times

  • It is important to keep the UI experience consistent with properties, and then the precise release time. Here is a comparison of the before and after changes.

image
After the change
image

klboke and others added 26 commits May 16, 2019 11:07
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2022

Codecov Report

Merging #4198 (1c8bf3e) into master (fec79aa) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4198   +/-   ##
=========================================
  Coverage     52.56%   52.56%           
  Complexity     2620     2620           
=========================================
  Files           484      484           
  Lines         15192    15192           
  Branches       1571     1571           
=========================================
  Hits           7986     7986           
  Misses         6649     6649           
  Partials        557      557           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fec79aa...1c8bf3e. Read the comment docs.

@klboke klboke requested a review from nobodyiam January 7, 2022 06:44
@klboke klboke added the area/ui Categorizes issue or PR as related to front end label Jan 8, 2022
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@nobodyiam nobodyiam merged commit 0e4542e into apolloconfig:master Jan 11, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 11, 2022
@nobodyiam nobodyiam added this to the 2.0.0 milestone Jan 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area/ui Categorizes issue or PR as related to front end

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants