fix show-text-modal-directive.js(#4131)#4183
Merged
nobodyiam merged 4 commits intoapolloconfig:masterfrom Jan 1, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4183 +/- ##
============================================
+ Coverage 52.55% 52.62% +0.06%
- Complexity 2617 2622 +5
============================================
Files 484 484
Lines 15201 15201
Branches 1572 1572
============================================
+ Hits 7989 7999 +10
+ Misses 6652 6647 -5
+ Partials 560 555 -5
Continue to review full report at Codecov.
|
Member
|
As this is a bug fix, would you please also update the CHANGES.md? |
Contributor
Author
Done |
nobodyiam
reviewed
Jan 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
fix #4131
case1
case2
case3
case4
case5
case6
case7
case8
Which issue(s) this PR fixes:
Fixes #4131
Brief changelog
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.CHANGESlog.