Merged
Conversation
`beanFactory.isTypeMatch` may lead to the initialization of FactoryBean, dubbo consumer is a ReferenceBean which implements FactoryBean. support spring 3 related to apolloconfig#2328 apolloconfig#3865 apolloconfig#4161 apolloconfig#4164
Codecov Report
@@ Coverage Diff @@
## master #4175 +/- ##
============================================
+ Coverage 52.56% 52.60% +0.03%
- Complexity 2614 2619 +5
============================================
Files 484 484
Lines 15190 15192 +2
Branches 1572 1571 -1
============================================
+ Hits 7985 7991 +6
+ Misses 6648 6645 -3
+ Partials 557 556 -1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
beanFactory.isTypeMatchmay lead to the initialization of FactoryBean,dubbo consumer is a ReferenceBean which implements FactoryBean.
support spring 3
related to #2328 #3865 #4161 #4164
What's the purpose of this PR
XXXXX
Which issue(s) this PR fixes:
Fixes #
Brief changelog
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.CHANGESlog.