You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The url https://www.apolloconfig.com/charts currently points to the charts directory, I think we also need to copy this charts folder to apollo-helm-chart.
As for the domain for apollo-helm-chart, how about charts.apolloconfig.com?
BTW, to keep backward compatibility, I think the charts directory should remain for a while so that users who haven't updated the charts repo could still fetch the current versions.
I have copied the charts directory to docs directory of apollo-helm-chart. And now the new helm repo url is https://charts.apolloconfig.com/.
So we could now merge this pr and I will submit another pr to update the chart repo URL later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
Split helm chart into another repo: https://github.com/apolloconfig/apollo-helm-chart
@nobodyiam We need to update the domain point to new
helm chart? Or Merge this after newhelm chartworks.Which issue(s) this PR fixes:
Fixes ##3959
Follow this checklist to help us incorporate your contribution quickly and easily:
CHANGESlog.