Fix flaky test testGetPropertyNames.#4082
Merged
nobodyiam merged 1 commit intoapolloconfig:masterfrom Nov 10, 2021
Merged
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Codecov Report
@@ Coverage Diff @@
## master #4082 +/- ##
============================================
- Coverage 52.45% 52.39% -0.06%
+ Complexity 2612 2609 -3
============================================
Files 484 484
Lines 15203 15203
Branches 1572 1572
============================================
- Hits 7974 7966 -8
- Misses 6675 6683 +8
Partials 554 554
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the flaky test testGetPropertyNames due to the non-deterministic iteration order of HashSet.
This flaky test is found by using Nondex, a tool used to find flaky tests in Java projects. The original assertion on Line#69 may fail because the iteration order of HashSet is non-deterministic, and the elements in the array converted from
somePropertyNamesmay not be the same as the arrayresult. By convertingresultto a HashSet, the new assertionassertEqualswill only check the elements are equal in both sets so that the test will always pass.