bump to 2.0.0 and drop java 1.7 support#4015
Merged
nobodyiam merged 1 commit intoapolloconfig:masterfrom Oct 9, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4015 +/- ##
============================================
- Coverage 51.54% 51.49% -0.06%
+ Complexity 2533 2530 -3
============================================
Files 484 484
Lines 14839 14839
Branches 1537 1537
============================================
- Hits 7649 7641 -8
- Misses 6658 6666 +8
Partials 532 532
Continue to review full report at Codecov.
|
Anilople
reviewed
Oct 6, 2021
Contributor
Anilople
left a comment
Anilople
left a comment
There was a problem hiding this comment.
Property <java.version>1.7</java.version> In module apollo-demo and apollo-mockserver should also delete?
Line 30 in 8484178
apollo/apollo-mockserver/pom.xml
Line 32 in 8484178
Member
Author
|
@Anilople Thanks for the reminder, I missed these places. |
Anilople
reviewed
Oct 7, 2021
Anilople
previously approved these changes
Oct 7, 2021
Anilople
approved these changes
Oct 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
bump to 2.0.0 and drop java 1.7 support
Which issue(s) this PR fixes:
see discussion #3896
Brief changelog
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.CHANGESlog.