Make the constructor of AbstractApolloHttpException implementation class to support string template#3999
Merged
nobodyiam merged 1 commit intoapolloconfig:masterfrom Sep 27, 2021
Conversation
…ass to support string template Signed-off-by: WillardHu <[email protected]>
a30bf2b to
538f7f8
Compare
Codecov Report
@@ Coverage Diff @@
## master #3999 +/- ##
============================================
+ Coverage 51.21% 51.27% +0.05%
- Complexity 2500 2505 +5
============================================
Files 482 482
Lines 14776 14773 -3
Branches 1527 1527
============================================
+ Hits 7568 7575 +7
+ Misses 6677 6667 -10
Partials 531 531
Continue to review full report at Codecov.
|
nobodyiam
reviewed
Sep 25, 2021
...n/src/main/java/com/ctrip/framework/apollo/common/exception/AbstractApolloHttpException.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: WillardHu [email protected]
What's the purpose of this PR
Make the constructor of
AbstractApolloHttpExceptionimplementation class to support string template. The methodcom.google.common.base.Strings.lenientFormat(..)performs better thanString.format(..).Which issue(s) this PR fixes:
Fixes #
Brief changelog
Make the constructor of AbstractApolloHttpException implementation class to support string template
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.CHANGESlog.