Skip to content

Extend GitHub client support Organization audit log call#18

Merged
alexpalvanov merged 5 commits intomainfrom
alexp/LIM-14998-extend-github-client-support-audit-log-calls
Jun 21, 2023
Merged

Extend GitHub client support Organization audit log call#18
alexpalvanov merged 5 commits intomainfrom
alexp/LIM-14998-extend-github-client-support-audit-log-calls

Conversation

@alexpalvanov
Copy link

Add support for getting last user activity date, by repository

@alexpalvanov alexpalvanov requested a review from a team June 20, 2023 07:40
@idanbd
Copy link

idanbd commented Jun 20, 2023

@TalfinApiiro I see a bunch of GitHub actions running here, I think they were added when you merged this fork with the original repository, we should probably remove them

idanbd
idanbd previously approved these changes Jun 20, 2023
@@ -0,0 +1,9 @@
using System;
using System.Reactive;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: not used

@@ -0,0 +1,19 @@
using System;
using System.Reactive;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: not used

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Comment on lines +20 to +21
Ensure.ArgumentNotNullOrEmptyString(organization, nameof(organization));
Ensure.ArgumentNotNullOrEmptyString(user, nameof(user));
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we ensure not null also for repository?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated


namespace Octokit
{
public class AuditLogActivity
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copied

@alexpalvanov alexpalvanov merged commit 192a397 into main Jun 21, 2023
@alexpalvanov alexpalvanov deleted the alexp/LIM-14998-extend-github-client-support-audit-log-calls branch June 21, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants